Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct mistaken "thunk" comment #1234

Merged
merged 2 commits into from
Jul 22, 2022
Merged

fix: correct mistaken "thunk" comment #1234

merged 2 commits into from
Jul 22, 2022

Conversation

erights
Copy link
Contributor

@erights erights commented Jul 18, 2022

Responding to suggestion at Agoric/agoric-sdk#5774 (comment)

When I changed the relevant logic from

  • taking a no-argument thunk parameter and calling thunk()

to

  • taking func and args parameters and calling func(...args)

I forgot to update the documentation to match. This PR fixes that oversight.

@erights erights requested a review from turadg July 18, 2022 03:22
@erights erights self-assigned this Jul 18, 2022
@erights erights mentioned this pull request Jul 18, 2022
Merged
@erights erights enabled auto-merge (squash) July 22, 2022 19:43
@erights erights merged commit f8b49d4 into master Jul 22, 2022
@erights erights deleted the markm-bad-thunk-documentation branch July 22, 2022 19:48
@Kashuhackerone Kashuhackerone mentioned this pull request Nov 5, 2022
Open
@Kashuhackerone Kashuhackerone mentioned this pull request Dec 25, 2022
Open
@Kashuhackerone Kashuhackerone mentioned this pull request Nov 27, 2023
Open
@Kashuhackerone Kashuhackerone mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @turadg