Ses-ava console virtualization: report to t.log instead of console

[kriskowal]

SES hides error stacks from callers and reveals them to the global console. SES-ava captures errors thrown in tests and reports them to the console to reveal their stacks, regardless of whether the test passes or fails, generating a great deal of decontextualized noise.

We would like to reveal the error to the test log buffer (t.log) instead. Since SES interacts thru the console API, we would need to virtualize the console for tests.

This console virtualization might be adaptable across other purposes.

[dckc]

see also #731

[dckc]

#701 is in this direction, yes?

[kriskowal]

Yes, very much so.

…

On Tue, Sep 14, 2021 at 1:56 PM Dan Connolly ***@***.***> wrote: #701 <#701> is in this direction, yes? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#891 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOXBXZ7IT636R3CP6XDMDUB6ZGZANCNFSM5EA7ML4Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[kriskowal]

To get here, we still need to tease out the compartment shim from ses.

[erights]

Hi @kriskowal , I said in #2109 that it would close this, and so co-assigned myself. But I don't understand your comments about needing compartment work, which #2109 does not do. If #2109 would not close this, please let me know what I'm missing.

[kriskowal]

I misunderstood what was necessary to accomplish this. Please disregard.