Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ses-ava is missing a todo method #645

Closed
erights opened this issue Mar 27, 2021 · 5 comments
Closed

ses-ava is missing a todo method #645

erights opened this issue Mar 27, 2021 · 5 comments
Assignees

Comments

@erights
Copy link
Contributor

erights commented Mar 27, 2021

While doing Agoric/agoric-sdk#2733 I discovered that our code uses test.todo occasionally but ses-ava does not yet support it.

@FUDCo you wanna?

@FUDCo
Copy link
Contributor

FUDCo commented Feb 3, 2022

Let's close this.

@erights
Copy link
Contributor Author

erights commented Feb 3, 2022

Close as in "it's already fixed, let's close the bug" or "let's fix this"?

@FUDCo
Copy link
Contributor

FUDCo commented Feb 3, 2022

As in "do we seriously care about this enough to, like, spend time on it?"

@erights
Copy link
Contributor Author

erights commented Feb 3, 2022

Sorry, yes we do. I see test.todo in 7 files in agoric-sdk. Six of these, as a result, are using ava when they should be using ses-ava. This causes diagnostic info to be lost and creates a lousy developer experience.

Doesn't need to be fixed by MN-1, but definitely needs to be fixed.

@turadg
Copy link
Member

turadg commented Dec 24, 2022

Closing as a case of the more general problem #647

@turadg turadg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants