fix: warning free lint

endojs · Jun 30, 2023 · a20ee00 · a20ee00
1 parent 5ede1b3
commit a20ee00
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 10 deletions.
diff --git a/packages/eventual-send/src/handled-promise.js b/packages/eventual-send/src/handled-promise.js
@@ -181,7 +181,7 @@ export const makeHandledPromise = () => {
       }
     }
 
-    assert.fail(
+    throw assert.fail(
       X`${q(handlerName)} is defined but has no methods needed for ${q(
         operation,
       )} (has ${q(getMethodNames(handler))})`,

diff --git a/packages/init/src/node-async_hooks.js b/packages/init/src/node-async_hooks.js
@@ -123,7 +123,7 @@ const findAsyncSymbolsFromPromiseCreateHook = () => {
         type = 'destroyed';
       } else {
         // process._rawDebug(`Unexpected symbol`, symbol);
-        return;
+        return undefined;
       }
 
       if (setAsyncSymbol(type, symbol)) {

diff --git a/packages/marshal/src/deeplyFulfilled.js b/packages/marshal/src/deeplyFulfilled.js
@@ -77,7 +77,7 @@ export const deeplyFulfilled = async val => {
       return E.when(val, nonp => deeplyFulfilled(nonp));
     }
     default: {
-      assert.fail(X`Unexpected passStyle ${q(passStyle)}`, TypeError);
+      throw assert.fail(X`Unexpected passStyle ${q(passStyle)}`, TypeError);
     }
   }
 };

diff --git a/packages/marshal/src/encodeToCapData.js b/packages/marshal/src/encodeToCapData.js
@@ -237,7 +237,7 @@ export const makeEncodeToCapData = (encodeOptions = {}) => {
         )}: ${encoded}`;
       }
       default: {
-        assert.fail(
+        throw assert.fail(
           X`internal: Unrecognized passStyle ${q(passStyle)}`,
           TypeError,
         );
@@ -446,7 +446,10 @@ export const makeDecodeFromCapData = (decodeOptions = {}) => {
           )}`;
         }
         default: {
-          assert.fail(X`unrecognized ${q(QCLASS)} ${q(qclass)}`, TypeError);
+          throw assert.fail(
+            X`unrecognized ${q(QCLASS)} ${q(qclass)}`,
+            TypeError,
+          );
         }
       }
     } else {

diff --git a/packages/marshal/src/encodeToSmallcaps.js b/packages/marshal/src/encodeToSmallcaps.js
@@ -263,7 +263,7 @@ export const makeEncodeToSmallcaps = (encodeOptions = {}) => {
         return result;
       }
       default: {
-        assert.fail(
+        throw assert.fail(
           X`internal: Unrecognized passStyle ${q(passStyle)}`,
           TypeError,
         );
@@ -372,7 +372,10 @@ export const makeDecodeFromSmallcaps = (decodeOptions = {}) => {
                 return -Infinity;
               }
               default: {
-                assert.fail(X`unknown constant "${q(encoding)}"`, TypeError);
+                throw assert.fail(
+                  X`unknown constant "${q(encoding)}"`,
+                  TypeError,
+                );
               }
             }
           }
@@ -454,7 +457,7 @@ export const makeDecodeFromSmallcaps = (decodeOptions = {}) => {
         return fromEntries(decodedEntries);
       }
       default: {
-        assert.fail(
+        throw assert.fail(
           X`internal: unrecognized JSON typeof ${q(
             typeof encoding,
           )}: ${encoding}`,

diff --git a/packages/marshal/src/marshal-justin.js b/packages/marshal/src/marshal-justin.js
@@ -393,7 +393,10 @@ const decodeToJustin = (encoding, shouldIndent = false, slots = []) => {
         }
 
         default: {
-          assert.fail(X`unrecognized ${q(QCLASS)} ${q(qclass)}`, TypeError);
+          throw assert.fail(
+            X`unrecognized ${q(QCLASS)} ${q(qclass)}`,
+            TypeError,
+          );
         }
       }
     } else if (isArray(rawTree)) {

diff --git a/packages/pass-style/src/passStyleOf.js b/packages/pass-style/src/passStyleOf.js
@@ -178,7 +178,7 @@ const makePassStyleOf = passStyleHelpers => {
           return 'remotable';
         }
         default: {
-          assert.fail(X`Unrecognized typeof ${q(typestr)}`, TypeError);
+          throw assert.fail(X`Unrecognized typeof ${q(typestr)}`, TypeError);
         }
       }
     };