feat(env-options): review suggestions

endojs · May 20, 2023 · 00c63b1 · 00c63b1
1 parent 16a3a7f
commit 00c63b1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/packages/env-options/README.md b/packages/env-options/README.md
@@ -1,6 +1,6 @@
 # Parameterizing Modules with Environment Options
 
-JavaScript module semantics resists attempts to parameterize a module's
+JavaScript module semantics resist attempts to parameterize a module's
 initialization behavior. A module initializes in order according to
 the path by which it is first imported, and then the initialized module
 is reused by all the other times it is imported. Compartments give us

diff --git a/packages/env-options/src/env-options.js b/packages/env-options/src/env-options.js
@@ -79,11 +79,6 @@ export const makeEnvironmentCaptor = aGlobal => {
         }
       }
     }
-    setting === undefined ||
-      typeof setting === 'string' ||
-      Fail`Environment option value ${q(
-        setting,
-      )}, if present, must be a string.`;
     return setting;
   };
   freeze(getEnvironmentOption);