Fix stale schema

[ulidtko]

Hi!

Two brief commits here, fixing issues in product-schema.json for validating the frontmatters.

See commit messages 👀

[welcome]

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

[ulidtko]

commit d28c0b2 👀

[ulidtko]

commit 4961fb8 👀

repairs product-schema.json staleness introduced in 1312fab — the actual schema has changed [method1, method2] → {"cumulative": bool, "methods": [method1, method2]}.

the large oneOf switch was factored out into $defs below.

[captn3m0]

I haven't worked a lot with the schema, happy to merge once I confirm the validation matches existing products.

[ulidtko]

I followed the guidance in CONTRIBUTING.md:

endoflife.date/CONTRIBUTING.md

Lines 415 to 418 in 111544a

	## ✅ Validating your changes
	If you're using an IDE like `vscode` or `vim` (or any other IDE that supports JSON schema validation),
	you can use [this jsonschema](./product-schema.json) to validate the new product.

On CLI... it's quite fiddly, I tried a few stock validators, none seem to work well with yaml frontmatters embedded in markdown.

Perhaps a little script can be written...

Yup, here's one ✍️

#!/usr/bin/env ruby

require('yaml')
require('json_schemer') #-- gem install json_schemer

#-- load product schema
product_schema = JSONSchemer.schema(
  JSON.load File.new("product-schema.json"),
  format: true,
  formats: {
    'date' => JSONSchemer::Format::DATE
  }
)
unless product_schema.valid_schema?
    puts "Warning: schema itself is not valid"
end

#-- Monkey-patch workaround, for an issue with YAML dates
#-- https://github.com/davishmcclurg/json_schemer/issues/203
class UnparsedDateMonkeyPatch
  def strptime strscalar, fmt, calendar
    strscalar #-- return input untouched, don't parse nothing.
  end
end
module YAML
  class ClassLoader
    class Restricted
      def find klassname
        return UnparsedDateMonkeyPatch.new if klassname == 'Date'
        super
      end
    end
  end
end

#-- iterate md frontmatters, validate, output errors if any
Dir.glob('products/*.md').select{|f| File.file? f}.each{|productmd|
  frontmatter = YAML.load_file(productmd, permitted_classes: [Date])

  product_schema.validate(frontmatter).each {|validation_result|
    printf "%s: %s\n", productmd, validation_result['error']
  }
}

@captn3m0 do you want this in-repo? I hadn't committed, because wasn't sure how to declare dependency on json_schemer. It doesn't belong in the main Gemfile, does it?..

---

Then, using the script, we can see there's been ever-increasing divergence of schema VS the product files. That's to be expected, because there's no enforcement of this validation in CI.

My fixes here improve the number of products files that pass validation:

• from 43/349 (306 with issues) on master
• to 221/349 (128 with issues) on this branch, freshly rebased.

[marcwrobel]

Thanks @ulidtko for this contribution