Add tag-related pages #3329
Merged
Add tag-related pages #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcwrobel
force-pushed
the
add-tag-pages
branch
3 times, most recently
from
ec8635d to
868d377
Compare
|
The new tag page is visible on https://deploy-preview-3329--endoflife-date.netlify.app/tags/. |
|
This will close #2225. |
marcwrobel
added a commit
that referenced
this pull request
Jul 30, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead.
marcwrobel
added a commit
that referenced
this pull request
Jul 30, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead.
marcwrobel
added a commit
that referenced
this pull request
Jul 30, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead.
marcwrobel
added a commit
that referenced
this pull request
Jul 30, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead.
marcwrobel
added a commit
that referenced
this pull request
Jul 30, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead. Closes #2350.
marcwrobel
force-pushed
the
add-tag-pages
branch
from
868d377 to
0c2c2c2
Compare
|
Looks good 🤩 |
marcwrobel
force-pushed
the
add-tag-pages
branch
from
88693ca to
e97f906
Compare
marcwrobel
commented
Aug 19, 2023
There was a problem hiding this comment.
Just re-checked and fixed a bugs.
Merging as:
- build pass,
- this is a nice addition to endoflife.date,
- this fixes a bug,
- this is mainly new pages, so it will not break other pages,
- this PR is quite old and did not received any review (seems like endoflife.date team members do not have much time these days),
- this may be needed for [new-product] Oracle JDK and OpenJDK builds from Oracle #3332.
@captn3m0 FYI.
marcwrobel
force-pushed
the
add-tag-pages
branch
from
e97f906 to
8852764
Compare
This adds: - a tag cloud page that lists all the tags, - a link at the left of the search bar to access the tag page, - a page for each tag, listing the products having the tag, - a link on each tag of product pages to access corresponding tag page. This also fixes a bug: auto icon was always displayed even if the product was not auto-updated. Don't know when fi it ever worked, but it has been fixed by also checking the auto array size. Closes #2225.
marcwrobel
force-pushed
the
add-tag-pages
branch
from
8852764 to
da34ff9
Compare
4 tasks
marcwrobel
added a commit
that referenced
this pull request
Aug 27, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead. Closes #2350.
marcwrobel
added a commit
that referenced
this pull request
Sep 24, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead. Closes #2350.
marcwrobel
added a commit
that referenced
this pull request
Sep 24, 2023
The current https://endoflife.date/java page is documenting both products, despite them being different. Old URLs (/java, /openjdk, /jdk) are now redirected to the new Oracle JDK page, as this page is similar to the old one. But once #3329 is merged, we could redirect to /tags/java-distribution instead. Closes #2350.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
This also fixes a bug: auto icon was always displayed even if the product was not auto-updated. Don't know when fi it ever worked, but it has been fixed by also checking the auto array size.