Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipados] Add links #2591

Merged
merged 2 commits into from
Mar 1, 2023
Merged

[ipados] Add links #2591

merged 2 commits into from
Mar 1, 2023

Conversation

marcwrobel
Copy link
Member

@marcwrobel marcwrobel commented Feb 25, 2023 •
edited
Loading

Relates to #39. Release notes are not published for all minor or patch versions, so using only the major version. Other release notes are easily accessible from that page, if available.

Also took the opportunity to normalize page (#2124).

@marcwrobel marcwrobel added the release-updates Pull Requests that update release information label Feb 25, 2023
BiNZGi
BiNZGi requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pattern seems not to be the same for all cycles:
https://developer.apple.com/documentation/ios-ipados-release-notes/ios-16-release-notes
https://developer.apple.com/documentation/ios-ipados-release-notes/ios-ipados-15-release-notes
https://developer.apple.com/documentation/ios-ipados-release-notes/ios-ipados-14-release-notes
https://developer.apple.com/documentation/ios-ipados-release-notes/ios-13-release-notes

changelogTemplate with ipados and add 16 and 13 as specific link. What do you think?

products/ipados.md Outdated Show resolved Hide resolved
products/ipados.md Show resolved Hide resolved
products/ipados.md Show resolved Hide resolved
@marcwrobel
[ipados] Normalize page (#2124)
9f9f667
@marcwrobel
[ipados] Add links (#39)
88dd3bc 
Release notes are not published for all minor or patch versions, so using only the major version. Other release notes are easily accessible from that page, if available.
@marcwrobel
Copy link
Member Author

Pattern seems not to be the same for all cycles:

You are right, and it depends. Sometime ios / ipados share the same release notes, and sometimes not. This is not consistent so I switched to links instead of the changelogTemplate. I also updated the link for 13 to use https://developer.apple.com/documentation/ios-ipados-release-notes/ios-ipados-13_1-release-notes : it seems 13.0 never existed (it is not listed on https://developer.apple.com/documentation/ios-ipados-release-notes/ and on https://en.wikipedia.org/wiki/IPadOS_13).

@marcwrobel marcwrobel requested a review from BiNZGi February 28, 2023 19:22
@marcwrobel marcwrobel changed the title [ipados] Add changelogTemplate [ipados] Add links Feb 28, 2023
BiNZGi
BiNZGi approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -> merge

@BiNZGi BiNZGi merged commit 2afd360 into master Mar 1, 2023
@BiNZGi BiNZGi deleted the ipados-links branch March 1, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiNZGi BiNZGi BiNZGi approved these changes

Assignees
No one assigned
Labels
release-updates Pull Requests that update release information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcwrobel @BiNZGi