-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProductDataEnricher
plugin to enrich product pages metadata
#2239
Conversation
@captn3m0, this PR is similar yours (#2226), but it contains only computations for what I need in the API (#2080). It works without any change to the product frontmatter (except a minor one for raspberrypi). I moved the following computations in this plugin
I have made a few test and it looks good enough to be merged IMHO. A few pages to test :
|
60ddbc2
to
4ad92cf
Compare
The https://deploy-preview-2239--endoflife-date.netlify.app/android has Could you also check for upcoming LTS? (No product has it right now, so test manually) |
Actually there is one, Devuan : https://deploy-preview-2239--endoflife-date.netlify.app/devuan. |
4ad92cf
to
bfb74a4
Compare
I forgot to replace one |
bfb74a4
to
2ecddb8
Compare
Conflicts with the just-merged PR #2157 resolved. |
@captn3m0 is it good enough to be merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With this approach, enriched data is only computed once and available both in layouts and in plugins (such as the APIv1 plugin - see #2080). This make things easier in both places.
validate.py
now checks ifreleaseLabel
is a string.This PR relates to (and conflicts with) #2226.