-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Harmonization #2036
Product Harmonization #2036
Conversation
Maybe we can also add tags to each product to help with such usecases? Since tags are cheap, we can tag projects with vendors, and other distinctions. Some example tags that wouldn't fit elsewhere:
And similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest undoing some confusing changes. Simple ones (Microsoft, Hashicorp) should be good.
Let's look at tags instead for such usecases.
I'm not sure about just 2 parts in this harmonization , Mysql and rabbitmq what do you think @captn3m0 @BiNZGi @marcwrobel ? |
Like @usta I would also leave |
I am OK for most Microsoft and Hashicorp changes: names like "Microsoft Windows" or "Hashicorp Consul" are commonly used. But I have never or rarely seen those :
Like @captn3m0 I think using tags would be much better / flexible to resolve the initial issue (which was perform some reporting on vendors). We could create a page and/or a JSON for each tag listing all the products with that tag (note: looks like https://just-the-docs.github.io does not have a "tag" feature). |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍
Hi @captn3m0 @marcwrobel @usta , I've applied patches, please let me know if I sould apply some more changes, like for "Oracle MySQL" 😸 |
How willl I be able to get them from API side ? |
I imagine a new path, '/api/tags/<tag_name>` that returns a response with a list of products (similar to the "All Products" endpoint). |
The product endpoint (#2062) should include tags as a list - don't think tags deserve an endpoint on their own. Till we have API up, you can easily generate these files locally by just reading the raw metadata from YAML files and dumping it as-is instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Squash Merging.
Awesome 👏 |
🚀 👏 🙏 |
👉 See #2016 for more details