Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Harmonization #2036

Merged
merged 22 commits into from
Dec 16, 2022
Merged

Product Harmonization #2036

merged 22 commits into from
Dec 16, 2022

Conversation

adriens
Copy link
Contributor

@adriens adriens commented Dec 14, 2022

👉 See #2016 for more details

@captn3m0
Copy link
Member

Maybe we can also add tags to each product to help with such usecases?

Since tags are cheap, we can tag projects with vendors, and other distinctions. Some example tags that wouldn't fit elsewhere:

  • cloud
  • infrastructure
  • amazon
  • microsoft
  • nosql
  • rdbms

And similar.

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest undoing some confusing changes. Simple ones (Microsoft, Hashicorp) should be good.

Let's look at tags instead for such usecases.

products/ansible.md Outdated Show resolved Hide resolved
products/mysql.md Outdated Show resolved Hide resolved
products/rabbitmq.md Outdated Show resolved Hide resolved
@usta
Copy link
Member

usta commented Dec 14, 2022

I'm not sure about just 2 parts in this harmonization , Mysql and rabbitmq
other than those 2 looks good to me. Yes i know oracle bought mysql and yes i know vmware bought rabbitmq
but in general those two never known with the name of these companies and adding name of these companies
infront of their title just will cause more confusion for users and make it harder for humans to find in list in left side of endoflife webpage [ as a user i never search mysql under oracle , or same i never search rabbitmq under vmware ] and i think this site doesnt have it and just ignore it [ if i was not using search bar or search function of browser ]

what do you think @captn3m0 @BiNZGi @marcwrobel ?

@BiNZGi
Copy link
Member

BiNZGi commented Dec 14, 2022

Like @usta I would also leave mysql and rabbitmq without the company. The products are not strongly tied to the company brand.

@marcwrobel
Copy link
Member

I am OK for most Microsoft and Hashicorp changes: names like "Microsoft Windows" or "Hashicorp Consul" are commonly used. But I have never or rarely seen those :

  • Microsoft Azure DevOps
  • Apple iPhone
  • Apple macOS
  • Red Hat Ansible
  • VMware RabbitMQ

Like @captn3m0 I think using tags would be much better / flexible to resolve the initial issue (which was perform some reporting on vendors). We could create a page and/or a JSON for each tag listing all the products with that tag (note: looks like https://just-the-docs.github.io does not have a "tag" feature).

@captn3m0
Copy link
Member

  • Tag pages are cheap and easy to setup, even if a theme doesn't support them.
  • I'm okay with the Apple prefix, since Apple iPhone is common enough phrasing, and grouping these products(so they're next to each other) makes sense.
  • Azure Devops does sound more accurate than Microsoft Azure Devops. Azure is already the parent brand here.

Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

Copy link
Contributor Author

@adriens adriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

@adriens
Copy link
Contributor Author

adriens commented Dec 15, 2022

Hi @captn3m0 @marcwrobel @usta , I've applied patches, please let me know if I sould apply some more changes, like for "Oracle MySQL" 😸

@adriens
Copy link
Contributor Author

adriens commented Dec 15, 2022

Maybe we can also add tags to each product to help with such usecases?

Since tags are cheap, we can tag projects with vendors, and other distinctions. Some example tags that wouldn't fit elsewhere:

* cloud

* infrastructure

* amazon

* microsoft

* nosql

* rdbms

And similar.

How willl I be able to get them from API side ?

@marcwrobel
Copy link
Member

How willl I be able to get them from API side ?

I imagine a new path, '/api/tags/<tag_name>` that returns a response with a list of products (similar to the "All Products" endpoint).

@captn3m0
Copy link
Member

 I imagine a new path, '/api/tags/<tag_name>` that returns a response with a list of products (similar to the "All Products" endpoint).

The product endpoint (#2062) should include tags as a list - don't think tags deserve an endpoint on their own. Till we have API up, you can easily generate these files locally by just reading the raw metadata from YAML files and dumping it as-is instead.

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Squash Merging.

@captn3m0 captn3m0 merged commit 89dd587 into endoflife-date:master Dec 16, 2022
@adriens
Copy link
Contributor Author

adriens commented Dec 17, 2022

I imagine a new path, '/api/tags/<tag_name>` that returns a response with a list of products (similar to the "All Products" endpoint).

Awesome 👏

@adriens
Copy link
Contributor Author

adriens commented Dec 18, 2022

🚀 👏 🙏

@marcwrobel marcwrobel added the product-updates Product content updates that are not fixes nor releases updates label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product-updates Product content updates that are not fixes nor releases updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants