Tixxdz/fleetctl improve unit lookup and wait #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 2, 2016 13:24
* tryWaitForUnitStates() tries to wait for units to reach the desired state. * getBlockAttempts() gets the correct value of how many attempts to try before giving up on an operation. These helpers will be used to make the code more consistent and clean. We do not intended to change any behaviour here.
…disk or the Registry
* Cover code path of getUnit*() functions with debug messages * Improve code comments
Improve code comments about getUnitFileFromTemplate() and kill some other useless code comments.
Add getUnitInstanceInfo() to check if the unit name is an instance of a template unit and while we are it improve the error handling.
… to be an instance
…ilesystem and registry
|
This tree looks good. But when getting into the detail, it's a little hard to follow each commit. Would it be better to reduce the number of commits, for example, by squashing relevant commits around GetUnitInstanceInfo()? |
|
@dongsupark you are right! and I'm trying to do that, yes the branch got long after the review from Jon, you can check the relevant PR here: coreos#1433 So I did handle all Jon comments. I force pushed that branch so commits were squashed! however I opened this PR here in our branch to track a CI functional test that was failing, I wanted to test it also before merging that PR... still in progress. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.