-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document player mods #11
Conversation
The change in question was released in 4.3.0, released in August.
A minimal editorconfig to set the file encoding keeps being added to my working copy – I think by Godot 4.4-dev3 – so let's commit it, and add some potentially-useful rules for editing .gd files in external editors.
Previously, half of the README was wrapped at 80 characters, while the other half used one long line per paragraph. It doesn't really matter which style is used; but it's nice to be consistent.
This improves the presentation of the player in the inspector.
For rationale, see <https://turso.tech/blog/simple-trick-to-save-environment-and-money-when-using-github-actions>. For the linting & formatting action, the concurrency group is set to contain the PR (if any) and ref otherwise, on the basis that only the latest push to a PR or branch is interesting. For the GitHub Pages and Godot Asset Library actions, each run overwrites the result of any previous run, so the concurrency group is just the workflow name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanation is great and the new linter keeps things consistent, thanks.
By the way, yes you can add a hyperlink to Wikipedia from a tooltip with:
[url]https://example.com[/url]
[url=https://example.com]Website[/url]
Yes, but you can't click links in tooltips! |
Ah right. You can left-click the property and -> Open Documentation, where you can click on links. Hmm I'm not sure what is better. Having a MODS file for all the moddings. Or each class documenting its own moddings in the builtin documentation. |
Hmm, OK, good point. The nice thing about the |
This adds a new sections to
MODS.md
, explaining all the parameters of Player, including those I added in #6 which have non-obvious names & semantics. Previously we were relying on the tooltips to explain what they mean but:I also added a few miscellaneous linter & formatting tweaks, which are basically the same as: