Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent Jenkins build included the wrong version of
collections.zip
because the one in the workspace was newer than the requested version. Let's try to fix this for real by making themake clean
target actually clean everything except for the p4a builds and the downloaded Kolibri wheel file. I checked the results withgit ls-files -o --directory
after a local build and think I got everything.With that,
make clean
can be run at the beginning of the Jenkins build (in addition to the existingp4a clean-builds
) and we can be reasonable sure that it will DTRT. The reason not to just wipe the workspace outright is that we want to keep the_cache
directory for the p4a downloads.One subtle difference is that the
src/kolibri
target was previously depending onclean
. Previously that was just cleaning up thedist
artifacts, but with the more thoroughclean
recipe, that would break everything. Instead, thedist
targets clean old artifacts as needed.Fixes: #806