Update to Kolibri 0.16.0-beta5 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release fixes cancelling of tasks so that stopping the worker instance actually stops the running tasks instead of waiting until they complete. The patch is no longer needed since it was merged upstream. Helps: endlessm/kolibri-explore-plugin#769
This reverts commit 4d22c7c. With kolibri 0.16.0-beta5, tasks can be stopped and there's less reason to try to split those up. Unlike `onDestroy`, `onStop` is always delivered, so this gives Kolibri a chance to stop. In theory it would be better to keep the process buses separate so that the server and worker run independently. However, that would only really be a benefit if they could be run in separate bound services. That's not supported in python-for-android, so for now it's better to run it all from the single python thread in the activity.
dylanmccall
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kolibri 0.16.0-beta5 fixes task cancellation, which means that the worker will actually cancel jobs when it's told to stop. With that I think we can revert the change to only stop the worker on destroy. It's conceptually nice to have the buses separate, but there are some drawbacks:
onDestroyonly happens afteronStopcompletes. That means the worker won't be stopped when until after the server has stopped. That exacerbates the black screen issue on ChromeOS since it's a much wider window where the app can be restarted while it's still being shut down.onStopis the only hook guaranteed to be run, so if you want the worker to shut down cleanly, it has to be done there.Helps: endlessm/kolibri-explore-plugin#769