build: Copy setup.cfg data to pyproject.toml #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to use newer versions of kolibri-tools, which will read configuration from `pyproject.toml` in preference to `setup.cfg`, if the former exists. See learningequality/kolibri#11146 For now, keep the old configuration present in `setup.cfg` as well, in case people are using an older version of kolibri-tools. That can be dropped once we bump our dependency. Signed-off-by: Philip Withnall <[email protected]>
|
This is actually only needed once kolibri-explore-plugin depends on a new-enough version of kolibri-tools that contains learningequality/kolibri#11146. At that point, our i18n would break without this PR, because kolibri-tools will read Submitting this PR now, even though it’s not actually needed yet, to avoid that potential trip hazard in future. |
|
Thank you @pwithnall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to use newer versions of kolibri-tools, which will read configuration from
pyproject.tomlin preference tosetup.cfg, if the former exists.See learningequality/kolibri#11146
For now, keep the old configuration present in
setup.cfgas well, in case people are using an older version of kolibri-tools. That can be dropped once we bump our dependency.