Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kolibri's FileDownloader #729

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Use Kolibri's FileDownloader #729

merged 3 commits into from
Aug 3, 2023

Conversation

starnight
Copy link
Contributor

We tried to fix download speed issue with Vendor old file download code.

However, Kolibri made some big change for FileDownloader since the commit ("Simplify Transfer subclasses now that they don't need to expose iterators.") included by v0.16.0-alpha19(+). And, our fix conflicts to the change and leads issue Download content failed after update Kolibri to v0.16.0-beta0.

I think this is the time using Kolibri's FileDownloader again.

Fixes: #728

@starnight starnight requested a review from dbnicholson August 3, 2023 10:13
@starnight starnight added the bug Something isn't working label Aug 3, 2023
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to verify that downloads are actually fixed, but I think this is for the best and any further regressions should probably be pursued upstream.

@starnight
Copy link
Contributor Author

Tested download speed of Artist package with Endless Key (Windows) 6.31.2.0 in Taipei office

  • Start: 2023-08-07 13:41:22
  • End: 2023-08-07 13:46:32

=> 5 minutes and 10 seconds -> Looks like around the speed as before.

@vanessa-chang
Copy link

Test on a chromebook, the download time takes longer compared to the production page.
chromebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download content failed after update Kolibri to v0.16.0-beta0
3 participants