Stop reversing classifications #836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test report ((Pydantic 2.x)206 tests 206 ✅ 6s ⏱️ Results for commit c39a448. |
Unit test report (Pydantic 1.x)206 tests 206 ✅ 6s ⏱️ Results for commit c39a448. |
sergei-encord
approved these changes
Jan 16, 2025
| @@ -1695,7 +1695,7 @@ def _to_classification_answers(self) -> Dict[str, Any]: | |||
| all_static_answers = classification.get_all_static_answers() | |||
| classifications = [answer.to_encord_dict() for answer in all_static_answers if answer.is_answered()] | |||
| ret[classification.classification_hash] = { | |||
| "classifications": list(reversed(classifications)), | |||
| "classifications": list(classifications), | |||
There was a problem hiding this comment.
Do we really need list constructor here as well? It's a list already, from what I can see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
For some reason, we reverse the order of our classifications in
to_encord_dict.Can't think of any good reason why we do this. It just results in classifications being in the wrong order in the UI.
JIRA
Link ticket(s)
Documentation
There should be enough internal documentation for a product owner to write customer-facing documentation or a separate PR linked if writing the customer documentation directly. Link all that are relevant below.
Tests
Make a quick statement and post any relevant links of CI / test results. If the testing infrastructure isn’t yet in-place, note that instead.
Known issues
If there are any known issues with the solution, make a statement about what they are and why they are Ok to leave unsolved for now. Make tickets for the known issues linked to the original ticket linked above