Improve code-quality and doc for democracy pallet #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
commented
May 28, 2024
democracy/src/lib.rs
Outdated
Comment on lines
482
to
487
| if let Ok(passing) = positive_turnout_bias { | ||
| if passing { | ||
| return Ok(true) | ||
| } | ||
| return Ok(false); | ||
| } | ||
| Ok(false) |
There was a problem hiding this comment.
I believe this code was a noop, so I removed it :)
clangenb
commented
May 28, 2024
Comment on lines
+63
to
+64
| use pallet_encointer_ceremonies::Pallet as CeremoniesPallet; | ||
| use pallet_encointer_communities::Pallet as CommunitiesPallet; |
There was a problem hiding this comment.
This prevents that some statements are expanded to multiple lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had completely forgotten how democracy works, so I tried to understand it by looking at the code. When I did that I found that I can improve some things along the way.