Implement sign and signature verification on ProofOfAttendance
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he proof of attendance's method.
…attendance signed constructor
clangenb
commented
Jan 18, 2024
Comment on lines
-229
to
-232
| impl<Signature, AccountId: Clone + Encode> ProofOfAttendance<Signature, AccountId> { | ||
| /// get the hash of the proof without the attendee signature, | ||
| /// as the signature is non-deterministic. | ||
| pub fn hash(&self) -> H256 { |
There was a problem hiding this comment.
I removed this, as it was unused.
clangenb
changed the title
ProofOfAttendance
brenzi
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just implemented this because I wanted to verify my dart proof of attendances in a simple unit test here. (Hint: dart already correctly signs proof of attendances ;))