-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare to publish to crates.io #358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
changed the title
polish toml files and first shot at bending all to crates.io
prepare to publish to crates.io
Oct 25, 2023
clangenb
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing striking, looks good to me.
I'll push a few changes once publish is done. Crates.io has a rate limit for new crates, so it takes a while... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #357 (apart from calling
cargo publish
)published crates to crates.io as new based on this PR
based on versions currently used for systemchain runtimes:
I think this can go into master because we should have no reasons anymore not to use crates.io for runtimes, nodes, collators aso.
*-rpc
crates will still live in this repo but will need to be sourced from crates.io. therefore, the entire collator repo needs to depend on crates.io (according to basti that should work. all necessary crates should be up to date there)I intend to first publish to crates.io and then merge. This feels wrong, but the problem is that the final check that these crates are ok will be including them in a runtime build, which I can only really test when the crates are actually fetched from crates.io
challenges: