Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare to publish to crates.io #358

Merged
merged 20 commits into from
Nov 2, 2023
Merged

prepare to publish to crates.io #358

merged 20 commits into from
Nov 2, 2023

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Oct 25, 2023

closes #357 (apart from calling cargo publish)

published crates to crates.io as new based on this PR

based on versions currently used for systemchain runtimes:

  • polish crate metadata
  • internalize TestRandomness because parity didn't publish frame-support-test to crates.io. tiny redundancy
  • skip publishing for non-production crates
  • all forked dependencies have been published already

I think this can go into master because we should have no reasons anymore not to use crates.io for runtimes, nodes, collators aso.

  • we could also remove the runtime from the parachain repo as parity is doing.
  • however, the *-rpccrates will still live in this repo but will need to be sourced from crates.io. therefore, the entire collator repo needs to depend on crates.io (according to basti that should work. all necessary crates should be up to date there)

I intend to first publish to crates.io and then merge. This feels wrong, but the problem is that the final check that these crates are ok will be including them in a runtime build, which I can only really test when the crates are actually fetched from crates.io

challenges:

  • local dependencies must define a version too. parity solves that with separate release-crates-io-* branches.

@brenzi brenzi changed the title polish toml files and first shot at bending all to crates.io prepare to publish to crates.io Oct 25, 2023
@brenzi brenzi marked this pull request as ready for review October 26, 2023 07:24
@brenzi brenzi requested a review from clangenb October 26, 2023 07:24
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing striking, looks good to me.

primitives/Cargo.toml Show resolved Hide resolved
@brenzi
Copy link
Member Author

brenzi commented Oct 27, 2023

I'll push a few changes once publish is done. Crates.io has a rate limit for new crates, so it takes a while...

@brenzi brenzi merged commit 8bcc998 into master Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish all productive pallets to crates.io
2 participants