Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polkadot update v0.9.42 #322

Merged
merged 18 commits into from
Jun 12, 2023
Merged

Polkadot update v0.9.42 #322

merged 18 commits into from
Jun 12, 2023

Conversation

OverOrion
Copy link
Contributor

Closes #313.

@OverOrion OverOrion force-pushed the szp/polkadot-v0.9.42 branch 2 times, most recently from df900b5 to 9b458e7 Compare June 5, 2023 12:53
@OverOrion OverOrion marked this pull request as ready for review June 8, 2023 15:16
@OverOrion OverOrion requested a review from clangenb June 8, 2023 15:16
clangenb
clangenb reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks in general very good thanks for the hard work!

I just saw at least one rebase error, which I would like you to fix. :)

ceremonies/src/lib.rs Show resolved Hide resolved
communities/Cargo.toml Outdated Show resolved Hide resolved
communities/src/lib.rs Show resolved Hide resolved
primitives/src/sybil.rs Outdated Show resolved Hide resolved
@clangenb
Copy link
Member

clangenb commented Jun 9, 2023 •
edited
Loading

This PR will also close #301

@OverOrion OverOrion requested a review from clangenb June 9, 2023 07:39
clangenb
clangenb reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for all the hard work here. It looks good to me now except for one type of inconsistency!

ceremonies/src/lib.rs Show resolved Hide resolved
communities/src/lib.rs Show resolved Hide resolved
faucet/src/lib.rs Show resolved Hide resolved
clangenb
clangenb approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brenzi brenzi changed the title [WIP] Polkadot update v0.9.42 Polkadot update v0.9.42 Jun 12, 2023
@brenzi brenzi merged commit 91d4889 into master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade dependencies to polkadot-0.9.42
4 participants
@OverOrion @clangenb @brenzi @pifragile