Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump substrate; handle removal of AccoundId32::default, add MaxEncodedLen support for some pallets #133

Merged
merged 20 commits into from
Jan 31, 2022
Merged

bump substrate; handle removal of AccoundId32::default, add MaxEncodedLen support for some pallets #133

merged 20 commits into from
Jan 31, 2022

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Jan 28, 2022 •
edited
Loading

@clangenb
bump sp-runtime, sp-keyring to v4.1.0-dev
3a307f0
@clangenb
bump rust-toolchain: 2022-01-26
7e9e6a8
@clangenb
cargo update
ecea8bb
@clangenb
[sybil-gate-template] change from ValueQuery to OptionQuery where…
56e4e9d 
… needed
@clangenb
[scheduler] change from ValueQuery to OptionQuery where needed
1adadc0
@clangenb
[communities] change from ValueQuery to OptionQuery where needed
2d8e493
@clangenb
update GeoHash to const generic version
edd26ef
@clangenb
[primitives] derive MaxEncodedLen for most types.
7b765e7
@clangenb
[bazaar] add pallet::without_storage_info because we can't satisfy …
69cfb21 
…`MaxEncodedLen` everywhere yet.
@clangenb
[ceremonies] derive MaxEncodedLen for some stuff
4015131
@clangenb
[ceremonies] use OptionQuery where necessary
b1e2734
@clangenb
[ceremonies] add pallet::without_storage_info because we can't sati…
7070344 
…sfy `MaxEncodedLen` everywhere yet.
@clangenb
[communities] incorporate GeoHash changes
77aa933
@clangenb
fix tests compilation; issue_rewards test fails.
a049013
@clangenb
[ceremonies] fix issue_rewards test.
3d4f14a
@clangenb
[ceremonies] improve code readability
1830113
@clangenb
bump [email protected] and remove patches for it.
8dc7448
@clangenb
bump [email protected] and remove patches for it.
cefbeb6
@clangenb
[ceremonies] better logs
5067faf
@clangenb
fix rebase errors
066770d
@clangenb clangenb changed the title bump substrate; handle removal of AccoundId32::default, add MaxEncodedLen support bump substrate; handle removal of AccoundId32::default, add MaxEncodedLen support for some pallets Jan 28, 2022
clangenb
clangenb commented Jan 28, 2022
View reviewed changes
bazaar/src/lib.rs
Comment on lines +51 to 52
#[pallet::without_storage_info]
pub struct Pallet<T>(PhantomData<T>);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substrate will make this forbidden in the future. By then, we need to have completely solved #132.

@clangenb clangenb requested a review from brenzi January 28, 2022 13:53
brenzi
brenzi approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@brenzi brenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some things are nicer now, others seem to get more complicated.....

@clangenb clangenb merged commit 3374abf into master Jan 31, 2022
@clangenb clangenb deleted the cl/bump-substrate branch January 31, 2022 10:52
@haerdib haerdib mentioned this pull request Feb 1, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenzi brenzi brenzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump sp-runtime, sp-keyring to v4.1.0-dev How to handle removal of AccountId32::default()
2 participants
@clangenb @brenzi