Docs: Nginx + websockets #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nginx requires that we set the Connection/Upgrade headers explicitly in the config, otherwise Nginx assumes that they shouldn't be forwarded. More info: https://nginx.org/en/docs/http/websocket.html
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying a new deployment using Nginx => Gunicorn => Uvicorn.
The app serves some websocket endpoints using Starlette.
I was getting 404 errors for every connection and didn't get any logging explaining what was happening.
After some debugging I found out that the Connection/Upgrade headers need to be set explicitly in the Nginx config, otherwise Nginx assumes that they shouldn't be forwarded.
More info: https://nginx.org/en/docs/http/websocket.html