-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter pytest #910
Stricter pytest #910
Conversation
interestingly the ci fails on windows....on other tests ! |
This reverts commit 5638047.
will continue on this when I'll have a windows machine, those errors are hard to debug because it's failing on weird places and to be honest the pytest messages are not helping |
haha closing this, the test suite changed and the new approach with context manager leads to way less issues it seems, will resurrect when/if #918 lands |
It seems to me we could benefit from a stricter pytest, especially the pytest.PytestUnhandledThreadExceptionWarning since we use threads a lot.
Moreover, test exceptions raised in a separate thread dont seem to be handled well with pytest, we have an example of this in the ws test suite, see #760 for instance.
This is also one of the reason our test suite behave strangely as sometimes the whole suite passes fine but seperate tests triggered on their own can fail.
With this pytest configuration we can see 2 issues, fixed after:
this is the error we would get with the stricter config, without the 2 fixes.