Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.2 #84

Merged
merged 26 commits into from
Jun 29, 2018
Merged

Version 0.2 #84

merged 26 commits into from
Jun 29, 2018

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Jun 27, 2018

  • Extensive improvements to error handling.
  • Adds an h11 implementation alongside the existing httptools - Can now run under PyPy.
  • Fixes access logs.
  • uvicorn command line now runs stand-alone, rather than under gunicorn. Gunicorn worker class documented.
  • Nice throughput bump.

TODO: WebSocket tests are hanging under travis.

@tomchristie tomchristie changed the title First pass at version 0.2 Version 0.2 Jun 28, 2018
@tomchristie
Copy link
Member Author

Going to take another go at resolving the websocket tests hanging under travis. They run to completion locally. I don’t want the release blocked on that so I might have to proceed anyway and come back to them.

Probably worth trying to remove the multi-threading and run them all under asyncio with pytest-asyncio or similar.

Any insights from anyone also much appreciated here!

@tomchristie
Copy link
Member Author

One other note on this... both the h11 and httptools implementations share exactly the same structure. I’m really happy with that as I think it’ll help keep maintainance lower, and it gives me a higher confidence in correctness.

I’ve also tackled it with later cythonisation in mind - sticking to basic data structures throughout.

Reminder to self: Break the cycle/protocol circular reference. Improve the read flow control so it blocks less often, using high/low watermarks instead of existing read/wait/read/wait style.

@tomchristie
Copy link
Member Author

Downgrade websockets version to a known passing case.
Worth investigating, since we will want to upgrade to the latest, but this should do for now.

@tomchristie
Copy link
Member Author

Also hanging on 4.0.1

@tomchristie
Copy link
Member Author

Okay, lets do this!

@tomchristie tomchristie merged commit 07c6c18 into master Jun 29, 2018
@tomchristie tomchristie deleted the version-0.2 branch June 29, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant