-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.2 #84
Version 0.2 #84
Conversation
Going to take another go at resolving the websocket tests hanging under travis. They run to completion locally. I don’t want the release blocked on that so I might have to proceed anyway and come back to them. Probably worth trying to remove the multi-threading and run them all under asyncio with pytest-asyncio or similar. Any insights from anyone also much appreciated here! |
One other note on this... both the h11 and httptools implementations share exactly the same structure. I’m really happy with that as I think it’ll help keep maintainance lower, and it gives me a higher confidence in correctness. I’ve also tackled it with later cythonisation in mind - sticking to basic data structures throughout. Reminder to self: Break the cycle/protocol circular reference. Improve the read flow control so it blocks less often, using high/low watermarks instead of existing read/wait/read/wait style. |
Downgrade websockets version to a known passing case. |
Also hanging on 4.0.1 |
Okay, lets do this! |
h11
implementation alongside the existinghttptools
- Can now run under PyPy.uvicorn
command line now runs stand-alone, rather than under gunicorn. Gunicorn worker class documented.TODO: WebSocket tests are hanging under travis.