Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace files by exclude on mypy configuration #1793

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Replace files by exclude on mypy configuration #1793

merged 1 commit into from
Dec 2, 2022

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Dec 2, 2022 •
edited
Loading

The idea here is to, instead of define the files covered, we'll now ignore the ones that are not covered, so if new files are created, we don't need to add them to the list.

@Kludex Kludex changed the title Replace files by exclude on mypy configuration Replace files by exclude on mypy configuration Dec 2, 2022
@Kludex Kludex requested a review from a team December 2, 2022 13:13
iudeen
iudeen approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping to do my part in reducing the exclude list 😁

@Kludex Kludex merged commit 918e9fa into master Dec 2, 2022
@Kludex Kludex deleted the mypy-remove-files branch December 2, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iudeen iudeen iudeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type Annotation and mypy support
2 participants
@Kludex @iudeen