Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotation to wsproto_impl.py #1754

Merged
merged 7 commits into from
Nov 20, 2022
Merged

Add type annotation to wsproto_impl.py #1754

merged 7 commits into from
Nov 20, 2022

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Nov 2, 2022 •
edited
Loading

Checklist

@Kludex Kludex marked this pull request as draft November 2, 2022 06:23
@Kludex Kludex mentioned this pull request Nov 2, 2022
Merged
13 tasks
@Kludex Kludex added this to the Version 0.21.0 milestone Nov 10, 2022
@Kludex Kludex marked this pull request as ready for review November 20, 2022 13:24
iudeen
iudeen approved these changes Nov 20, 2022
View reviewed changes
Copy link
Contributor

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!🚀

@Kludex Kludex merged commit 917aff0 into master Nov 20, 2022
@Kludex Kludex deleted the annotate/wsproto branch November 20, 2022 16:35
@Kludex Kludex requested a review from a team November 21, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iudeen iudeen iudeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.21.0
Development

Successfully merging this pull request may close these issues.

Type Annotation and mypy support
2 participants
@Kludex @iudeen