Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a previous discussion about this: encode/httpx#1680
One of the goals is to reduce the time on the pipeline, the other is to reduce the amount of networking resources. 🙏
There were no arguments against this, only a note (my own) about the fact that we always need to install the latest dependencies from the
setup.py
(nowpyproject.toml
).The thing is that the cache entry is removed (if not used) after 7 days, see here. Also, once a month we have updates via Dependabot on the
requirements.txt
, which triggers a new cache entry. Which means once a month we'll have the latestuvicorn
dependencies - I think it's reasonable.