Add default headers to WebSockets implementations
#1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adopted change suggested. Co-authored-by: Marcelo Trylesinski <[email protected]>
as per suggestion, moved the limitation to --no-server-header area
Added logic to add server header support for websockets and also to pass default headers
Added logic to add server header support for websockets and also to pass default headers
* added logic to accept default headers in websocket * added default_headers to class init * fix * feat(websockets): added server header support for websockets Added logic to add server header support for websockets and also to pass default headers * feat(websockets-wsproto): added server header support for websockets Added logic to add server header support for websockets and also to pass default headers Co-authored-by: Irfanuddin <[email protected]>
# Conflicts: # uvicorn/protocols/websockets/websockets_impl.py # uvicorn/protocols/websockets/wsproto_impl.py
…sockets" This reverts commit 62c6c7e
--no-date-header is also not compatible with Websockets
--no-date-header is also not compatible with Websockets
Suggestion removes duplication check on header names to keep it consistent with http implementations. Co-authored-by: Marcelo Trylesinski <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Irfanuddin <[email protected]>
iudeen
commented
Oct 27, 2022
iudeen
commented
Oct 27, 2022
Kludex
reviewed
Oct 28, 2022
|
Merged suggestions given by Marcelo in #1736 |
Kludex
reviewed
Oct 28, 2022
| @pytest.mark.anyio | ||
| @pytest.mark.parametrize("ws_protocol_cls", ONLY_WS_PROTOCOL) | ||
| @pytest.mark.parametrize("http_protocol_cls", HTTP_PROTOCOLS) | ||
| async def test_no_date_header(ws_protocol_cls, http_protocol_cls): |
There was a problem hiding this comment.
This is not 100% true. I forgot to mention... The Date headers from the websockets cannot be removed... 🤔
Should we do something about it on the tests? It's on purpose... 🤔
It's a question, I'm still thinking.
There was a problem hiding this comment.
Do what on tests? There is no way to remove date header in websockets I think.
There was a problem hiding this comment.
I mean, I know, but the tests make us believe that we forgot about Date headers... 🤔
Kludex
reviewed
Oct 28, 2022
Co-authored-by: Marcelo Trylesinski <[email protected]>
Kludex
approved these changes
Oct 28, 2022
Kludex
changed the title
WebSockets implementations
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Irfanuddin <[email protected]> Co-authored-by: Irfanuddin <[email protected]>
Kludex
added a commit
that referenced
this pull request
Oct 29, 2022
Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Irfanuddin <[email protected]> Co-authored-by: Irfanuddin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #1581 for detailed discussion.
Feature Description:
This feature fixes the issue that discussed in #1574
Currently it implements support for
no-server-headerforwsprotoimplementations.