Remove conditional on RemoteProtocolError.event_hint

[Kludex]

I'm not sure if this is the right code, but events.CloseConnection receives code as a mandatory field, so without it, you'll have an exception on missing parameters.

List of codes: https://www.iana.org/assignments/websocket/websocket.xhtml
RFC: https://www.rfc-editor.org/rfc/rfc6455.html

I've noticed this issue while annotating wsproto_impl.

EDIT: Quite funny... wsproto doesn't raise a RemoteProtocolError without an event_hint. Check their source code: https://github.com/python-hyper/wsproto/.

[tomchristie]

Well spotted.

How about we use 1002 "Protocol Error"? That seems like it'd fit quite well here.

[Kludex]

The handle_no_connect() method ignores the code from the event anyway. I guess there needs to be some change there.

[Kludex]

I've replaced the logic here. 😅

[tomchristie]

Do we pause this until there's a resolution to python-hyper/wsproto#178, or are we okay with knowing that event_hint isn't ever None in this context, although it's annotated as Optional?

[Kludex]

I'm fine with this being merged. Thanks @tomchristie 🙏

As a note, wsproto_impl.py is the only file that is missing to add type annotation on uvicorn folder. I'll work on that this week.