Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for _subprocess.py #1477

Merged
merged 3 commits into from
May 9, 2022
Merged

Add tests for _subprocess.py #1477

merged 3 commits into from
May 9, 2022

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented May 6, 2022 •
edited
Loading 

Name                                           Stmts   Miss     Cover   Missing
-------------------------------------------------------------------------------
uvicorn/_subprocess.py                            21      1    95.24%   70
uvicorn/config.py                                299     14    95.32%   141-142, 326-327, 331, 361, 517-519, 545-546, 552-554
uvicorn/middleware/proxy_headers.py               33      1    96.97%   44
uvicorn/protocols/http/flow_control.py            34      6    82.35%   25, 38-40, 44-45
uvicorn/protocols/http/h11_impl.py               295      9    96.95%   117-118, 237-238, 306, 312, 410, 413, 428
uvicorn/protocols/http/httptools_impl.py         323      9    97.21%   117-118, 171, 312, 318, 416, 419, 451, 453
uvicorn/protocols/websockets/wsproto_impl.py     216     27    87.50%   19, 68, 79, 89, 102, 104, 114, 120, 123-126, 158-169, 207-214
uvicorn/server.py                                176     43    75.57%   105-121, 125-131, 135-144, 156-159, 178-179, 185, 198, 241-243, 259, 270-273, 303-306
uvicorn/supervisors/basereload.py                 51      7    86.27%   43-48, 81, 90
-------------------------------------------------------------------------------
TOTAL                                           4807    117    97.57%

@Kludex Kludex requested review from euri10 and tomchristie May 6, 2022 05:29
@Kludex Kludex added this to the Version 0.18.0 milestone May 6, 2022
@Kludex Kludex requested a review from a team May 6, 2022 06:20
euri10
euri10 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, more coverage !

@Kludex Kludex merged commit ea24c7e into master May 9, 2022
@Kludex Kludex deleted the add-tests-subprocess branch May 9, 2022 18:39
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
@Kludex
Add tests for _subprocess.py (encode#1477)
6c9e7f7 
* Add tests for `_subprocess.py`

* Ignore coverage on windows

* Add another ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euri10 euri10 euri10 approved these changes

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Kludex @euri10