Moved warning about missing ws library only in upgrade case #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is there a need for coverage downgrade if there's a no pragma? |
|
I added it in this PR to try fix the coverage downgrade but it wasn't enough so I fixed it like that, which is bad, but the pragma wasnt in the previous commit and the coverage should have dropped there, so really I dont know, seems flacky |
tomchristie
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Similarly to @Kludex I also don't get the nocover/coverage change.
But also I don't care enough about that for it to block the PR.
(Because correctness wins as a priority)
|
Ok I merge and will dig into the coverage stuff later |
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1352
Solves the issue raised in #1352 (comment)