Add option to set websocket ping interval and timeout #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this merged |
Co-authored-by: Marcelo Trylesinski <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
done ! that's why another pair of eyes is so important >_) |
Kludex
approved these changes
Jun 9, 2021
Co-authored-by: Marcelo Trylesinski <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
Kludex
added a commit
that referenced
this pull request
Nov 17, 2021
* Add max size to webosckets implementation * Adde ping interval and timeout to websockets inplmenetation * Post-merge glitches corrected * Added some docs * Corrected flags Co-authored-by: Marcelo Trylesinski <[email protected]> * Corrected flags Co-authored-by: Marcelo Trylesinski <[email protected]> * Updated docs * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <[email protected]> * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Marcelo Trylesinski <[email protected]>
|
@euri10 |
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* Add max size to webosckets implementation * Adde ping interval and timeout to websockets inplmenetation * Post-merge glitches corrected * Added some docs * Corrected flags Co-authored-by: Marcelo Trylesinski <[email protected]> * Corrected flags Co-authored-by: Marcelo Trylesinski <[email protected]> * Updated docs * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <[email protected]> * Update docs/settings.md Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Marcelo Trylesinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
I tested this manually and can see ping/pong frames flying when I set it to a low interval, but could not find a clever way to add tests as I do not know exactly what should be tested since the ping/pong mechanism is automatically handled by websockets, maybe someone would have an idea