Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add types to wsgi module #1018

Closed
wants to merge 1 commit into from
Closed

add types to wsgi module #1018

wants to merge 1 commit into from

Conversation

jkklapp
Copy link
Contributor

@jkklapp jkklapp commented Apr 15, 2021 •
edited
Loading

Part of #998

@Kludex
Copy link
Member

Kludex commented May 29, 2021 •
edited
Loading

@jkklapp Thanks for the PR! 🎉

We're now using asgiref.typing instead of _types.py module. Do you mind updating this PR using asgiref.typing instead?

@Vibhu-Agarwal
Copy link
Contributor

@Kludex May I extend this PR?
(Commits by @jkklapp will remain)

@Kludex
Copy link
Member

Kludex commented Jun 9, 2021

@Vibhu-Agarwal You're more than welcome.

@Kludex
Copy link
Member

Kludex commented Jun 9, 2021

Thanks for the PR @jkklapp ! :)
I guess @Vibhu-Agarwal will take the lead now, and as he said, your contributions will not be erased! 🎉

Thanks for volunteering here @Vibhu-Agarwal 😄

@Kludex Kludex closed this Jun 9, 2021
@Vibhu-Agarwal Vibhu-Agarwal mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkklapp @Kludex @Vibhu-Agarwal