Check wsproto response status code

encode · Dec 3, 2023 · 80797c9 · 80797c9
1 parent 435e6dc
commit 80797c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/tests/protocols/test_websocket.py b/tests/protocols/test_websocket.py
@@ -1114,6 +1114,8 @@ async def test_server_reject_connection_with_invalid_status(
     http_protocol_cls,
     unused_tcp_port: int,
 ):
+    # this test checks that even if there is an error in the response, the server
+    # can successfully send a 500 error back to the client
     async def app(scope, receive, send):
         assert scope["type"] == "websocket"
         assert "websocket.http.response" in scope["extensions"]

diff --git a/uvicorn/protocols/websockets/wsproto_impl.py b/uvicorn/protocols/websockets/wsproto_impl.py
@@ -307,6 +307,10 @@ async def send(self, message: "ASGISendEvent") -> None:
 
                 elif message_type == "websocket.http.response.start":
                     message = typing.cast("WebSocketResponseStartEvent", message)
+                    # ensure status code is in the valid range
+                    if not (100 <= message["status"] < 600):
+                        msg = "Invalid HTTP status code '%d' in response."
+                        raise RuntimeError(msg % message["status"])
                     self.logger.info(
                         '%s - "WebSocket %s" %d',
                         self.scope["client"],