-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove converter from path when generating OpenAPI
schema
#1648
Conversation
@@ -49,10 +50,11 @@ def get_endpoints( | |||
|
|||
for route in routes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
route
may not have path attribute, that's why the path =...
is not here.
Hi, thank you for fixing this so quickly. Just a quick question: Why not put it into the next bug fix release e.g. 0.20.4 instead 0.21? Unfortunately I am a bit stuck continuing my code until this is fixed. |
Yeah, it can be on 0.20.4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, yup. One suggestion, but not a blocker.
Co-authored-by: Tom Christie <[email protected]>
To be more correct, I'd have to add the information about the type of the path parameter...