Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing tweaks #164

Merged
merged 6 commits into from
Oct 30, 2018
Merged

Routing tweaks #164

merged 6 commits into from
Oct 30, 2018

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Oct 30, 2018

  • Ensure url_path_for works with Mount('/{some_path_params}')
  • Fix Router(default=) argument
  • Support repeated paths, like: @app.route("/", methods=["GET"]), @app.route("/", methods=["POST"])
  • Use the default ThreadPoolExecutor for all sync endpoints.

@tomchristie tomchristie merged commit 96c51c9 into master Oct 30, 2018
@tomchristie tomchristie deleted the routing-tweaks branch October 30, 2018 16:08
marcosschroh pushed a commit to marcosschroh/starlette that referenced this pull request Oct 31, 2018
* Ensure url_path_for works with Mount('/{some_path_params}')

* Fix Router(default=) argument

* Support partial matches on routing, to support handlers with same path, but different methods.

* Run sync views in threadpool

* Use default executor for WSGI middleware
laggardkernel added a commit to laggardkernel/starlette that referenced this pull request Mar 3, 2021
Param "workers" in WSGIMiddleware.__ini__ has not been used
since 0.6.3, which is changed in encodeGH-164, commit 96c51c.
laggardkernel added a commit to laggardkernel/starlette that referenced this pull request Mar 3, 2021
Param "workers" in WSGIMiddleware.__init__ has not been used
since 0.6.3, which is changed in encodeGH-164, commit 96c51c.
laggardkernel added a commit to laggardkernel/starlette that referenced this pull request Mar 3, 2021
Param "workers" in WSGIMiddleware.__init__ has not been used
since 0.6.3, which is changed in encodeGH-164, commit 96c51c.
laggardkernel added a commit to laggardkernel/starlette that referenced this pull request Jun 13, 2021
Param "workers" in WSGIMiddleware.__init__ has not been used
since 0.6.3, which is changed in encodeGH-164, commit 96c51c.
JayH5 added a commit that referenced this pull request Jun 13, 2021
Param "workers" in WSGIMiddleware.__init__ has not been used
since 0.6.3, which is changed in GH-164, commit 96c51c.

Co-authored-by: Jamie Hewland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant