Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.20.0 #1600

Merged
merged 10 commits into from
May 3, 2022
Merged

Version 0.20.0 #1600

merged 10 commits into from
May 3, 2022

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Apr 22, 2022

@Kludex Kludex added this to the Version 0.20.0 milestone Apr 24, 2022
docs/release-notes.md Outdated Show resolved Hide resolved
@Kludex Kludex requested a review from a team April 28, 2022 06:29
April 28, 2022

### Removed
* Drop Python 3.6 support [#1357](https://github.com/encode/starlette/pull/1357).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the checklist be added here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What items do you think should be included?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have written rules for the changelog on starlette, but tests, docs and type hints modifications were never included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I meant the doc changes, but you're right, they were never part of release changes.

@Kludex Kludex requested a review from aminalaee May 1, 2022 16:53
@Kludex Kludex requested a review from a team May 2, 2022 11:53
@@ -1,3 +1,11 @@
## 0.20.0

April 28, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly reminder about this :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would have forgotten! 😅

docs/release-notes.md Outdated Show resolved Hide resolved
@Kludex Kludex merged commit 830f348 into master May 3, 2022
@Kludex Kludex deleted the release/0.20.0 branch May 3, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants