Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WSGIMiddleware in favor of a2wsgi #1504

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Deprecate WSGIMiddleware in favor of a2wsgi #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35fa30d
Deprecate `WSGIMiddleware` in favor of `a2wsgi`
Kludex Feb 10, 2022
286500f
Add deprecation warning to the setup.cfg
Kludex Feb 10, 2022
b13116f
Merge branch 'master' into deprecate-wsgi-middleware
adriangb Feb 11, 2022
3824d3e
Merge branch 'master' into deprecate-wsgi-middleware
tomchristie Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/middleware.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,3 +305,7 @@ can be used to profile and monitor distributed applications.

A middleware class to emit timing information (cpu and wall time) for each request which
passes through it. Includes examples for how to emit these timings as statsd metrics.

#### [WSGIMiddleware](https://github.com/abersheeran/a2wsgi)

A middleware class in charge of converting a WSGI application into an ASGI one.
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ filterwarnings=
ignore: The 'variables' alias has been deprecated. Please use 'variable_values' instead\.:DeprecationWarning
# Workaround for Python 3.9.7 (see https://bugs.python.org/issue45097)
ignore:The loop argument is deprecated since Python 3\.8, and scheduled for removal in Python 3\.10\.:DeprecationWarning:asyncio
ignore: starlette\.middleware\.wsgi is deprecated and will be removed in a future release\.*:DeprecationWarning

[coverage:run]
source_pkgs = starlette, tests
Expand Down
7 changes: 7 additions & 0 deletions starlette/middleware/wsgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,18 @@
import math
import sys
import typing
import warnings

import anyio

from starlette.types import Receive, Scope, Send

warnings.warn(
"starlette.middleware.wsgi is deprecated and will be removed in a future release. "
"Please refer to https://github.com/abersheeran/a2wsgi as a replacement.",
DeprecationWarning,
)


def build_environ(scope: Scope, body: bytes) -> dict:
"""
Expand Down