Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed - async __call__ not run/awaited in the BackgroundTask #1256

Closed
wants to merge 13 commits into from
Closed

Fixed - async __call__ not run/awaited in the BackgroundTask #1256

wants to merge 13 commits into from

Conversation

dpr-0
Copy link

@dpr-0 dpr-0 commented Jul 29, 2021

Reference to #886

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On starlette/endpoints.py we also use the same asyncio.iscoroutinefunction. We probably want to use the same iscoroutinefunction there as well.

Maybe we should move the function to other module?

@dpr-0
Copy link
Author

dpr-0 commented Sep 17, 2021

Yeah, so should I work on this branch or checkout to a new branch for this iscoroutinefunction function?

@Kludex
Copy link
Member

Kludex commented Sep 17, 2021

It can be here.

@dpr-0
Copy link
Author

dpr-0 commented Sep 17, 2021

It can be here.

I see. Thanks for reviewing this pull request. Considering current module names might be not completely suitable for this function, it seems like there can be a new module like utils.py for this function.

@dpr-0 dpr-0 requested a review from Kludex September 23, 2021 03:02
@Kludex
Copy link
Member

Kludex commented Nov 15, 2021

I guess the function was moved, so we could also do the replacement on the starlette/endpoints.py?

@adriangb adriangb added the bug Something isn't working label Feb 2, 2022
@dpr-0
Copy link
Author

dpr-0 commented Mar 12, 2022

I guess the function was moved, so we could also do the replacement on the starlette/endpoints.py?

Hi, I am back for this thread. Should I do the replacement now?

@Kludex
Copy link
Member

Kludex commented Mar 14, 2022

I'm not sure. I think we should look for #1444, but I don't know the opinion of the other members.

@dpr-0
Copy link
Author

dpr-0 commented Mar 19, 2022

I'm not sure. I think we should look for #1444, but I don't know the opinion of the other members.

Yeah, I understand that, please let me know if there is any update about this thread. Thanks.
Maybe there is other tickets I can be assigned right now.

@Kludex
Copy link
Member

Kludex commented Apr 21, 2022

@dpr-0 Thanks for this PR! Also, sorry for taking long to take action here.

I'm going to push forward to #1444, so I'll be closing this.

@Kludex Kludex closed this Apr 21, 2022
@dpr-0
Copy link
Author

dpr-0 commented Apr 21, 2022

@Kludex No problem, Thanks for fixing this issue at #1444 !

@Kludex
Copy link
Member

Kludex commented Apr 21, 2022

Thank you for the patience here! 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants