-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed - async __call__ not run/awaited in the BackgroundTask #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On starlette/endpoints.py
we also use the same asyncio.iscoroutinefunction
. We probably want to use the same iscoroutinefunction
there as well.
Maybe we should move the function to other module?
Yeah, so should I work on this branch or checkout to a new branch for this |
It can be here. |
I see. Thanks for reviewing this pull request. Considering current module names might be not completely suitable for this function, it seems like there can be a new module like |
I guess the function was moved, so we could also do the replacement on the |
Hi, I am back for this thread. Should I do the replacement now? |
I'm not sure. I think we should look for #1444, but I don't know the opinion of the other members. |
Yeah, I understand that, please let me know if there is any update about this thread. Thanks. |
Thank you for the patience here! 🙇♂️ |
Reference to #886