👷 Add Python venv cache #1216
👷 Add Python venv cache #1216
Conversation
|
I'll put on "hold" until the |
There was a problem hiding this comment.
- The implication here is that we now pin our dev dependencies and somebody updates them every once in a while? (Seems we're not so keen on dependabot because it creates too many PRs)
- Before/after "benchmarks" would be appreciated 🙏 although I understand you're waiting for this to move further along with httpx for now, so no rush.
| python-multipart | ||
| pyyaml | ||
| requests | ||
| -e .[full] |
There was a problem hiding this comment.
Do we really want to do [full]? These dependencies then won't be pinned and so will only be updated implicitly when the cache is invalidated.
| @@ -21,13 +21,25 @@ jobs: | |||
| - uses: "actions/setup-python@v2" | |||
| with: | |||
| python-version: "${{ matrix.python-version }}" | |||
|
|
|||
| - uses: actions/[email protected] | |||
There was a problem hiding this comment.
What's the reason for asking for such a specific version?
|
I think overall I don't really have a problem with the build time as things are (~3min or less) so I'm not sure this is worth the extra complexity? |
Echoing encode/uvicorn#1095 (comment) Agreed. Let's take things one step at a time. 😀
I do also share this outlook somewhat. Not definitively, but tentatively. |
|
I'm closing this, as we still have to discuss on HTTPX. |
Following the same idea as encode/httpx#1680 and encode/uvicorn#1095.
This PR aims to add a cache to the Python environment.