Small Pythonic code changes for datastructures.py file #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Apr 27, 2021
.gitignore
Outdated
| @@ -11,3 +11,6 @@ venv*/ | |||
| .python-version | |||
| build/ | |||
| dist/ | |||
| .idea/ | |||
There was a problem hiding this comment.
Those ignores are not going to be accepted 😅
There was a problem hiding this comment.
ahahaha :D Okay reverting back)
.gitignore
Outdated
| @@ -10,4 +10,4 @@ site/ | |||
| venv*/ | |||
| .python-version | |||
| build/ | |||
| dist/ | |||
| dist/ | |||
There was a problem hiding this comment.
Why remove the new line at the end? :)
fuadaghazada
approved these changes
Apr 28, 2021
Kludex
requested changes
Jun 10, 2021
There was a problem hiding this comment.
@ShahriyarR Thanks for the PR! 🎉
The two first changes I think it does improve readability. But I don't feel the same for the last two. Can you check my comments?
starlette/datastructures.py
Outdated
| for idx, (item_key, item_value) in enumerate(self._list): | ||
| if item_key == set_key: | ||
| found_indexes.append(idx) | ||
| found_indexes = [ |
There was a problem hiding this comment.
This is controversial. Not everybody believes it's an improvement. I'd prefer to not change it.
starlette/datastructures.py
Outdated
| for idx, (item_key, item_value) in enumerate(self._list): | ||
| if item_key == del_key: | ||
| pop_indexes.append(idx) | ||
| pop_indexes = [ |
Kludex
approved these changes
Jun 11, 2021
|
@Kludex awesome merge :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to simplify and add more style :)
Thanks.