Skip to content

Commit

Permalink
fix(testclient): exclude query sting from raw_path (#2716)
Browse files Browse the repository at this point in the history
Co-authored-by: Marcelo Trylesinski <[email protected]>
  • Loading branch information
raptium and Kludex authored Nov 18, 2024
1 parent cc1e2d7 commit 9dc9d2e
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
4 changes: 2 additions & 2 deletions starlette/testclient.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ def handle_request(self, request: httpx.Request) -> httpx.Response:
scope = {
"type": "websocket",
"path": unquote(path),
"raw_path": raw_path,
"raw_path": raw_path.split(b"?", 1)[0],
"root_path": self.root_path,
"scheme": scheme,
"query_string": query.encode(),
Expand All @@ -300,7 +300,7 @@ def handle_request(self, request: httpx.Request) -> httpx.Response:
"http_version": "1.1",
"method": request.method,
"path": unquote(path),
"raw_path": raw_path,
"raw_path": raw_path.split(b"?", 1)[0],
"root_path": self.root_path,
"scheme": scheme,
"query_string": query.encode(),
Expand Down
24 changes: 24 additions & 0 deletions tests/test_testclient.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,3 +378,27 @@ def homepage(request: Request) -> Response:
client = test_client_factory(app, base_url="http://testserver/api/v1/")
response = client.get("/bar")
assert response.text == "/api/v1/bar"


def test_raw_path_with_querystring(test_client_factory: TestClientFactory) -> None:
async def app(scope: Scope, receive: Receive, send: Send) -> None:
response = Response(scope.get("raw_path"))
await response(scope, receive, send)

client = test_client_factory(app)
response = client.get("/hello-world", params={"foo": "bar"})
assert response.content == b"/hello-world"


def test_websocket_raw_path_without_params(test_client_factory: TestClientFactory) -> None:
async def app(scope: Scope, receive: Receive, send: Send) -> None:
websocket = WebSocket(scope, receive=receive, send=send)
await websocket.accept()
raw_path = scope.get("raw_path")
assert raw_path is not None
await websocket.send_bytes(raw_path)

client = test_client_factory(app)
with client.websocket_connect("/hello-world", params={"foo": "bar"}) as websocket:
data = websocket.receive_bytes()
assert data == b"/hello-world"

0 comments on commit 9dc9d2e

Please sign in to comment.