Moved create and verify ssl context function into the utils and included lru cache. #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansarigol
force-pushed
the
cache_ssl_context
branch
5 times, most recently
from
4bab0af to
cb78e5e
Compare
|
Hi @cansarigol, thanks for tackling this! From what I can see, this PR tries to address both #978 and #983. It's probably best that we keep fixes for these separate. Most likely #983 is higher priority, as it would make |
cansarigol
force-pushed
the
cache_ssl_context
branch
from
cb78e5e to
76bb86c
Compare
|
Hi @florimondmanca , I thought that we can handle in a single PR and I can include a test about |
|
Closing in favour of #996 |
|
Incidentally let's not jump straight in with implementing SSLContext caching once #996 is in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #978
globally caching our SSL contexts suggestion of @tomchristie .