Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for httpcore 0.9 interface. #967

Merged
merged 5 commits into from
May 21, 2020
Merged

Updates for httpcore 0.9 interface. #967

merged 5 commits into from
May 21, 2020

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented May 21, 2020 •
edited
Loading

Needs to pin to httpcore 0.9 once available.

  • Pass proxy_url instead of proxy_origin.
  • Update signature of transport classes to have port as an Optional[int].

@tomchristie tomchristie added this to the v0.13 milestone May 21, 2020
@tomchristie tomchristie marked this pull request as ready for review May 21, 2020 12:04
@tomchristie tomchristie mentioned this pull request May 21, 2020
Closed
@tomchristie tomchristie changed the title Pass proxy_url Updates for httpcore 0.9 interface. May 21, 2020
@tomchristie tomchristie mentioned this pull request May 21, 2020
Merged
@tomchristie
Copy link
Member Author

Pulling this in now, to fix the builds.

@tomchristie tomchristie merged commit 9b6605c into master May 21, 2020
@tomchristie tomchristie deleted the pass-proxy-url branch May 21, 2020 12:21
@tomchristie tomchristie mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.
1 participant
@tomchristie