Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge existing params in url, close #3433 #3438

Closed
wants to merge 4 commits into from

Conversation

GreyElaina
Copy link
Contributor

@GreyElaina GreyElaina commented Dec 2, 2024

Summary

Revert #3364

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Edit by @Kludex :

@GreyElaina GreyElaina marked this pull request as ready for review December 2, 2024 18:03
Kludex
Kludex previously approved these changes Dec 3, 2024
@Kludex
Copy link
Member

Kludex commented Dec 3, 2024

Can we add a test here, so we are sure this doesn't break again in the future?

@Kludex Kludex self-requested a review December 3, 2024 07:33
@Kludex Kludex dismissed their stale review December 3, 2024 07:34

We need a test.

@GreyElaina
Copy link
Contributor Author

Can we add a test here, so we are sure this doesn't break again in the future?

no problem, will present later.

@GreyElaina
Copy link
Contributor Author

@Kludex tests are ready.

@tomchristie
Copy link
Member

tomchristie commented Dec 3, 2024

Thanks, tho see #3433 (comment).

My suggestion would be...

  • Introduce tests for the 0.28.0 behaviour.
  • Include a release note item in 0.28.0 documenting the behavior change.

@GreyElaina
Copy link
Contributor Author

Thanks, tho see #3433 (comment).

My suggestion would be...

* Introduce tests for the 0.28.0 behaviour.

* Include a release note item in 0.28.0 documenting the behavior change.

fine, see you another pr
close is welcome.

@tomchristie tomchristie closed this Dec 3, 2024
@GreyElaina GreyElaina deleted the patch-1 branch December 3, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing query params in url when params option is set
4 participants