Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Add Python venv cache #1680

Closed
wants to merge 10 commits into from
Closed

👷 Add Python venv cache #1680

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7953ccd
👷 Add Python venv cache
Kludex Jun 12, 2021
3adc6ad
Merge branch 'master' into ci/add-env-cache
tomchristie Jun 14, 2021
9116ea7
Merge branch 'master' into ci/add-env-cache
tomchristie Jun 14, 2021
51bdac8
💚 Fix cache path
Kludex Jun 14, 2021
b7f8ce9
empty commit to test cache
Kludex Jun 14, 2021
6418b9d
use python locationn
Kludex Jun 14, 2021
266d344
empty commit to test cache
Kludex Jun 14, 2021
b767261
Merge branch 'master' into ci/add-env-cache
Kludex Jun 16, 2021
53ca0d0
Merge branch 'master' into ci/add-env-cache
Kludex Jun 28, 2021
4b11d9a
Merge branch 'master' into ci/add-env-cache
Kludex Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,25 @@ jobs:
- uses: "actions/setup-python@v2"
with:
python-version: "${{ matrix.python-version }}"

- uses: actions/[email protected]
id: cache-requirements
with:
path: ${{ env.pythonLocation }}
key: ${{ env.pythonLocation }}-${{ matrix.python-version }}-${{ hashFiles('requirements.txt', 'setup.py') }}
Copy link
Member

@tomchristie tomchristie Jun 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where have you gotten ${{ env.pythonLocation }} from?
(I mean, it looks neat, but I don't understand it)

I don't see anything about it mentioned in the docs, here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from this tutorial.

But it's defined on the setup-action above. Here specifically: https://github.com/actions/setup-python/blob/dc73133d4da04e56a135ae2246682783cc7c7cb6/src/find-python.ts#L62


- name: "Install dependencies"
run: "scripts/install"
if: steps.cache-requirements.outputs.cache-hit != 'true'

- name: "Run linting checks"
run: "scripts/check"

- name: "Build package & docs"
run: "scripts/build"

- name: "Run tests"
run: "scripts/test"

- name: "Enforce coverage"
run: "scripts/coverage"