Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CertTypes keyfile and password should be Optional types. #1503

Merged
merged 1 commit into from
Mar 10, 2021
Merged

CertTypes keyfile and password should be Optional types. #1503

merged 1 commit into from
Mar 10, 2021

Conversation

decaz
Copy link
Contributor

@decaz decaz commented Mar 9, 2021

Fixes #1502.

florimondmanca
florimondmanca reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks. Just a small idea.

httpx/_types.py Show resolved Hide resolved
@decaz decaz requested a review from florimondmanca March 10, 2021 07:48
@tomchristie tomchristie changed the title Fix CertTypes CertTypes keyfile and password should be Optional types. Mar 10, 2021
tomchristie
tomchristie approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks decent. Thanks!

@tomchristie tomchristie merged commit 24a55d7 into encode:master Mar 10, 2021
@florimondmanca
Copy link
Member

Thanks @decaz!

@tomchristie tomchristie mentioned this pull request Mar 12, 2021
Merged
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Closed
This was referenced Mar 16, 2021
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

@florimondmanca florimondmanca Awaiting requested review from florimondmanca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CertTypes keyfile and password should be Optional types.
3 participants
@decaz @florimondmanca @tomchristie