-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly preserve encoded slashes when using base_url
#1407
Conversation
base_url
base_url
Great, yup this is a reasonable change. I'm going to scrub the "Closes 1405" notation in the description, since the OP there doesn't note any usage of base_url, so although it's been a useful prompt onto this, which is a nice little tweak, I don't think it's relevant to what they're seeing. |
@tomchristie Makes sense! Are we ✅ on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely & neat, yup!
I can confirm that this PR does fix the concrete test of #1405 (comment). [ Apologies for previous confusion in this comment, I had ended up with parallel installations of 0.15.0 and this branch. ] 12:33 $ pip show httpx |
👍 Thanks all! |
Thank you! Do you know yet when a new release might be made? |
Update: Prompted by #1405
An alternative to #1406 that tweaks URL merging to operate on
.raw_path
, rather than.path
. Rationale:.path
is URL-decoded and might swallow pre-existing%2F
characters into/
. On the other hand.raw_path
doesn't do URL-decoding, so it is suitable for handling encoded slashes as well.