Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepalive_expiry to Limits config #1398

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Nov 24, 2020

Closes #1395

We do also want #1302, but I think it makes sense to include keepalive_expiry in the Limits config either ways around.

@tomchristie tomchristie added the enhancement New feature or request label Nov 24, 2020
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple enough, yes. :-)

Don't think we have it yet, but it strikes me that a "Pooling configuration" section in the advanced docs could be a good contribution, and this new option could easily be showcased there.

@tomchristie
Copy link
Member Author

@florimondmanca Yeah that'd be a good one. TBH I think we could really do with completely overhauling our docs structure. We've mirrored requests so far, but actually I could see us doing better with more sections, and going into depth in each.

URLs, Headers, Request/Response content, Cookies, Authentication, Concurrency, Proxies, SSL, HTTP/2, Connection Pooling, etc...

Having fuller sections for each would also let us fill them out in more depth with good learning material, whereas when everything follows on in the advanced section we kinda have to keep each bit relatively brief.

@tomchristie tomchristie merged commit d0835da into master Nov 25, 2020
@tomchristie tomchristie deleted the keepalive-expiry-in-limits branch November 25, 2020 15:32
@florimondmanca
Copy link
Member

@tomchristie Yes, I also feel like our docs could use some overhaul and restructuring... As always, docs from trio projects like trio and h11 are great inspiration sources on what could be. :) Tutorials for common problems and highlighting some best practices or common gotchas, in-depth guides about various pieces of functionality, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize Keep-Alive timeout
2 participants