-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keepalive_expiry to Limits config #1398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple enough, yes. :-)
Don't think we have it yet, but it strikes me that a "Pooling configuration" section in the advanced docs could be a good contribution, and this new option could easily be showcased there.
@florimondmanca Yeah that'd be a good one. TBH I think we could really do with completely overhauling our docs structure. We've mirrored requests so far, but actually I could see us doing better with more sections, and going into depth in each. URLs, Headers, Request/Response content, Cookies, Authentication, Concurrency, Proxies, SSL, HTTP/2, Connection Pooling, etc... Having fuller sections for each would also let us fill them out in more depth with good learning material, whereas when everything follows on in the advanced section we kinda have to keep each bit relatively brief. |
@tomchristie Yes, I also feel like our docs could use some overhaul and restructuring... As always, docs from trio projects like trio and h11 are great inspiration sources on what could be. :) Tutorials for common problems and highlighting some best practices or common gotchas, in-depth guides about various pieces of functionality, etc. |
Closes #1395
We do also want #1302, but I think it makes sense to include
keepalive_expiry
in theLimits
config either ways around.